Check duplicate interfaces only for metadata #73797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
RikkiGibson
reviewed
May 31, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
May 31, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
May 31, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Show resolved
Hide resolved
|
Done with review pass (commit 2) |
|
Done with review pass (commit 3) |
|
@RikkiGibson for another look, thanks |
RikkiGibson
reviewed
Jun 11, 2024
| public interface I<T> { } | ||
| """; | ||
|
|
||
| CompileAndVerify(CreateCompilationWithMscorlib40(source), symbolValidator: validate).VerifyDiagnostics(); |
There was a problem hiding this comment.
I think it is interesting to also know what the source symbol does. Is it going to have interface I<T> twice with different nullability?
RikkiGibson
reviewed
Jun 11, 2024
|
|
||
| partial class C1<T> : I< | ||
| T, | ||
| #nullable disable |
There was a problem hiding this comment.
I think it would also be interesting to test when the lexical first declaration has a nullable-disabled type argument
RikkiGibson
reviewed
Jun 11, 2024
|
@RikkiGibson for another look, thanks |
RikkiGibson
reviewed
Jun 13, 2024
| var interfaces = c.AllInterfacesNoUseSiteDiagnostics; | ||
| Assert.Equal(2, interfaces.Length); | ||
| AssertEx.Equal("I<T>", interfaces[0].ToTestDisplayString(includeNonNullable: true)); | ||
| AssertEx.Equal("I<T>", interfaces[1].ToTestDisplayString(includeNonNullable: true)); |
There was a problem hiding this comment.
Does this mean that these actually have exactly the same type? If not, consider adjusting the comparison so that the distinction between the two types are clear.
RikkiGibson
approved these changes
Jun 14, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40538.
Fixes dotnet/razor#9837.
First commit extracted out of #73730.