-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer implicit span conversions #73765
Merged
jjonescz
merged 18 commits into
dotnet:features/FirstClassSpan
from
jjonescz:FirstClassSpan-03-Betterness
Jun 14, 2024
Merged
Prefer implicit span conversions #73765
jjonescz
merged 18 commits into
dotnet:features/FirstClassSpan
from
jjonescz:FirstClassSpan-03-Betterness
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
May 29, 2024
jjonescz
force-pushed
the
FirstClassSpan-03-Betterness
branch
from
May 29, 2024 13:50
cf54931
to
3225d8a
Compare
cston
approved these changes
Jun 4, 2024
cston
approved these changes
Jun 4, 2024
333fred
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there places that we updated to avoid ambiguities in the bootstrap build that should be put back?
jjonescz
changed the base branch from
dev/jjonescz/FirstClassSpan-02
to
features/FirstClassSpan
June 13, 2024 12:15
jjonescz
force-pushed
the
FirstClassSpan-03-Betterness
branch
from
June 13, 2024 12:19
e57cb21
to
c6ad725
Compare
cston
approved these changes
Jun 13, 2024
333fred
approved these changes
Jun 13, 2024
jjonescz
merged commit Jun 14, 2024
638cf61
into
dotnet:features/FirstClassSpan
25 of 28 checks passed
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Compilers
Feature - First-class Span Types
untriaged
Issues and PRs which have not yet been triaged by a lead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding speclet update: dotnet/csharplang#8149
Test plan: #73445