Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer implicit span conversions #73765

Merged

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented May 29, 2024

Corresponding speclet update: dotnet/csharplang#8149
Test plan: #73445

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 29, 2024
@jjonescz jjonescz force-pushed the FirstClassSpan-03-Betterness branch from cf54931 to 3225d8a Compare May 29, 2024 13:50
@jjonescz jjonescz marked this pull request as ready for review May 29, 2024 16:02
@jjonescz jjonescz requested a review from a team as a code owner May 29, 2024 16:02
@jjonescz jjonescz requested review from 333fred and cston June 4, 2024 11:40
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there places that we updated to avoid ambiguities in the bootstrap build that should be put back?

@jjonescz jjonescz changed the base branch from dev/jjonescz/FirstClassSpan-02 to features/FirstClassSpan June 13, 2024 12:15
@jjonescz jjonescz force-pushed the FirstClassSpan-03-Betterness branch from e57cb21 to c6ad725 Compare June 13, 2024 12:19
@jjonescz jjonescz requested a review from a team as a code owner June 13, 2024 12:19
@jjonescz jjonescz requested a review from 333fred June 13, 2024 13:28
@jjonescz jjonescz merged commit 638cf61 into dotnet:features/FirstClassSpan Jun 14, 2024
25 of 28 checks passed
@jjonescz jjonescz deleted the FirstClassSpan-03-Betterness branch June 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - First-class Span Types untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants