Create stronger type to expression compilation tracker internal policy #72673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 22, 2024
| /// Skeleton references should only be created for a compilation if no existing skeleton exists for their | ||
| /// project from some point in the past. | ||
| /// </summary> | ||
| CreateIfAbsent, |
There was a problem hiding this comment.
Note: this state will be used in teh followup PR.
ToddGrun
reviewed
Mar 22, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Mar 22, 2024
| { | ||
| Contract.ThrowIfNull(finalCompilationWithGeneratedDocuments); | ||
|
|
||
| // As a policy, all partial-state projects are said to have incomplete references, since the | ||
| // state has no guarantees. | ||
| this.CompilationWithoutGeneratedDocuments = compilationWithoutGeneratedDocuments; | ||
| HasSuccessfullyLoaded = hasSuccessfullyLoaded && !isFrozen; |
There was a problem hiding this comment.
yes it was. deciding to freeze things doesn't have any impact on our determination if things successfully loaded or not.
|
/azp run Roslyn-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #72494.
Allows us to express succintly teh behavior we want in the compilation tracker around running SGs or generating skeleton references.