Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include privates when emitting skeleton references #72645

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Do not include privates when emitting skeleton references #72645

merged 1 commit into from
Mar 21, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Note: this puts the compiler into produce ref assembly mode, which is the ideal semantics we want here.

@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun March 21, 2024 18:27
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 21, 2024 18:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 21, 2024
ToddGrun
ToddGrun approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 6eb98bb into dotnet:main Mar 21, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 21, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the includePrivates branch March 21, 2024 19:57
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski For review when you get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @RikkiGibson