Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EOL versions #72623

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update EOL versions #72623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12d15ed
Update EOL versions
richlander Mar 20, 2024
358132c
Apply suggestions from code review
richlander Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ variables:

- name: UbuntuQueueName
${{ if eq(variables['System.TeamProject'], 'public') }}:
value: Build.Ubuntu.1804.Amd64.Open
value: Build.Ubuntu.2004.Amd64.Open
${{ else }}:
value: Build.Ubuntu.1804.Amd64
value: Build.Ubuntu.2004.Amd64

- name: WindowsQueueName
${{ if eq(variables['System.TeamProject'], 'public') }}:
Expand All @@ -79,9 +79,9 @@ variables:

- name: HelixUbuntuQueueName
${{ if eq(variables['System.TeamProject'], 'public') }}:
value: Ubuntu.1804.Amd64.Open
value: Ubuntu.2004.Amd64.Open
${{ else }}:
value: Ubuntu.1804.Amd64
value: Ubuntu.2004.Amd64

- name: HelixMacOsQueueName
${{ if eq(variables['System.TeamProject'], 'public') }}:
Expand Down Expand Up @@ -148,23 +148,23 @@ stages:
# Like template `eng/common/templates/jobs/source-build.yml`
- job: Source_Build_Managed
displayName: Source-Build (Managed)
container: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8
container: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0
richlander marked this conversation as resolved.
Show resolved Hide resolved
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: $[replace(replace(eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], 'refs/heads/main'), 'release'), 'true'), True, 'NetCore-Svc-Public' ), False, 'NetCore-Public')]
demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why here it's 2204 and above it's 2004?

Copy link
Member Author

@richlander richlander Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended pattern is:

  • For raw VM usage, use oldest supported Ubuntu
  • For container-based testing, use the newest (for the host VM)


${{ if eq(variables['System.TeamProject'], 'internal') }}:
name: $[replace(replace(eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], 'refs/heads/main'), 'release'), 'true'), True, 'NetCore1ESPool-Svc-Internal'), False, 'NetCore1ESPool-Internal')]
demands: ImageOverride -equals Build.Ubuntu.1804.Amd64
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64
workspace:
clean: all
steps:
- template: /eng/common/templates/steps/source-build.yml
parameters:
platform:
name: 'Managed'
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8'
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0'
richlander marked this conversation as resolved.
Show resolved Hide resolved

- stage: Windows_Debug_Desktop
dependsOn: Windows_Debug_Build
Expand Down
Loading