Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #69628 Analyzer summary should show suppressor ID #72569

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Fix #69628 Analyzer summary should show suppressor ID #72569

merged 3 commits into from
Mar 20, 2024
+10 −2

Conversation

juan-carlos-diaz
Copy link
Contributor

This PR fix #69628.

The fix show the Ids for the supported suppressions when the analyzer report is generated.

Test modified to include checking for Ids.

@juan-carlos-diaz juan-carlos-diaz requested a review from a team as a code owner March 15, 2024 22:42
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 15, 2024
@juan-carlos-diaz
Copy link
Contributor Author

@juan-carlos-diaz please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

333fred
333fred approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler for a second review.

@333fred 333fred merged commit 20f2319 into dotnet:main Mar 20, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 20, 2024
@333fred
Copy link
Member

333fred commented Mar 20, 2024

Thanks for the contribution @juan-carlos-diaz!

333fred added a commit that referenced this pull request Mar 20, 2024
@333fred
Merge remote-tracking branch 'upstream/main' into demo/razor-lexer
460e5e4 
* upstream/main: (1045 commits)
  Fix excessive compilation times due to speculative parsing after an incomplete string (#72565)
  Convert official pipeline to 1ES template (#72430)
  Fix #69628 Analyzer summary should show suppressor ID (#72569)
  Fix event hookup even when in a projection buffer
  Drop win32-ia32 language server support
  Remove workaround for .net7 r2r assembly loading issue
  remove unused usings
  Share compilation when generators don't produce any generated files
  Fix potential exception in AssetProvider.SynchronizeAssetsAsync (#72597)
  Fix
  Update __arglist.md (#72523)
  Improve code gen for concatenation of `string` and `char` (#71793)
  Reduce File I/O under the AnalyzerAssemblyLoader folder (#72412)
  Reduce allocations in AbstractTypeMap (#72588)
  disable diagnostics when solution crawler option is disabled
  disable diagnostics when solution crawler option is disabled
  better thread transitions
  Fix
  Add check
  Fix
  ...
@juan-carlos-diaz juan-carlos-diaz deleted the users/jcdiaz/issue-69628 branch March 24, 2024 13:29
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Analyzers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.

Analyzer summary should show suppressor ID
5 participants
@juan-carlos-diaz @333fred @jjonescz @RikkiGibson @juan-diaz-at-nicklaus