Surface a warning at the declaration site for language incompatible [InlineArray] types #69144
Conversation
…InlineArray] types Closes dotnet#68867
dotnet-issue-labeler
bot
added
the
untriaged
|
@tannergooding FYI |
| @@ -7700,4 +7700,10 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ | |||
| <data name="WRN_InlineArrayConversionOperatorNotUsed_Title" xml:space="preserve"> | |||
| <value>Inline array conversion operator will not be used for conversion from expression of the declaring type.</value> | |||
| </data> | |||
| <data name="WRN_InlineArrayNotSupportedByLanguage" xml:space="preserve"> | |||
| <value>'Inline arrays' language feature is not supported for inline array types with element field which is either a 'ref' field, or has type that is not valid as a type argument.</value> | |||
There was a problem hiding this comment.
Why a separate error for ref fields? Couldn't ERR_InlineArrayUnsupportedElementFieldModifier be used for that? #Resolved
There was a problem hiding this comment.
Why a separate error for ref fields? Couldn't
ERR_InlineArrayUnsupportedElementFieldModifierbe used for that?
It cannot. The ERR_InlineArrayUnsupportedElementFieldModifier is an error. This is a warning. And it is reported for scenarios other than ref fields as well.
|
@cston, @dotnet/roslyn-compiler For the second review |
| @@ -1754,9 +1754,12 @@ protected override void AfterMembersCompletedChecks(BindingDiagnosticBag diagnos | |||
|
|
|||
| if (TryGetPossiblyUnsupportedByLanguageInlineArrayElementField() is FieldSymbol elementField) | |||
| { | |||
| bool reported_ERR_InlineArrayUnsupportedElementFieldModifier = false; | |||
There was a problem hiding this comment.
Consider naming this
reportInlineArrayNotSupported, and set totruein the case of pointers or restricted types below, so the error can be reported in one location rather than two.
I am not sure what you have in mind exactly. Could you elaborate, please?
ghost
added this to the 
Closes #68867
Relates to test plan #67826