Do not offer string (or other type-keywords) after ref/readonly inside namespace member declaration
#67097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait a minute, why is |
Because the others don't interfere with typing. So i'm only addressing the core case that is problematic. |
|
Maybe pull that logic up to |
|
Sure. i can try that. |
|
Moved up. Thanks :) |
DoctorKrolic
reviewed
Mar 1, 2023
| if (token.Kind() is SyntaxKind.ReadOnlyKeyword) | ||
| token = syntaxTree.FindTokenOnLeftOfPosition(token.SpanStart, cancellationToken); | ||
|
|
||
| // if we're not after `ref` or `ref readonly` then don't offer `string` here. |
There was a problem hiding this comment.
Suggested change
| // if we're not after `ref` or `ref readonly` then don't offer `string` here. | |
| // if we're not after `ref` or `ref readonly` then don't offer keyword here. |
...Portable/Completion/KeywordRecommenders/AbstractSpecialTypePreselectingKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
...Portable/Completion/KeywordRecommenders/AbstractSpecialTypePreselectingKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Mar 1, 2023
...Portable/Completion/KeywordRecommenders/AbstractSpecialTypePreselectingKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
…stractSpecialTypePreselectingKeywordRecommender.cs
Co-authored-by: DoctorKrolic <[email protected]>
CyrusNajmabadi
changed the title
string afer ref/readonly inside namespace member declarationstring (or other type-keywords) after ref/readonly inside namespace member declaration
akhera99
approved these changes
Mar 6, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67061
This is both not legal, and interferes with typing
ref structsincestringsorts abovestruct.