Avoid deep recursion while emitting deeply nested logical conditions #66993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler Please review |
2 similar comments
|
@dotnet/roslyn-compiler Please review |
|
@dotnet/roslyn-compiler Please review |
|
cc @jaredpar |
jjonescz
reviewed
Feb 24, 2023
| // fallThrough: | ||
|
|
||
| object fallThrough = null; | ||
| var stack = ArrayBuilder<(BoundExpression? condition, StrongBox<object?> destBox, bool sense)>.GetInstance(); |
There was a problem hiding this comment.
Why is dest wrapped in a StrongBox? Why not store just object? in the stack? #Resolved
There was a problem hiding this comment.
Why is dest wrapped in a
StrongBox? Why not store justobject?in the stack?
Its value is mutable and is supposed to be shared between different items on the stack (including mutations). If we simply store object?, we will store its current value (often null) and won't be able to observe the changes. We need an indirection in order to be able share the mutations as well. StrongBox gives us an indirection.
jjonescz
approved these changes
Feb 24, 2023
|
@dotnet/roslyn-compiler For the second review |
cston
approved these changes
Feb 24, 2023
AlekseyTs
commented
Feb 24, 2023
cston
approved these changes
Feb 24, 2023
jjonescz
approved these changes
Feb 24, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66900.