Filter source generator diagnostics by SuppressMessageAttribute
#66965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
force-pushed
the
66337-SG-SuppressMessageAttribute
branch
from
8ca43c1 to
fcacd65
Compare
jaredpar
reviewed
Feb 22, 2023
| @@ -1280,6 +1280,92 @@ void verifyDiagnosticsWithSource(string source, (Diagnostic, TextSpan)[] reportD | |||
| } | |||
| } | |||
|
|
|||
| [Fact, WorkItem(66337, "https://github.com/dotnet/roslyn/issues/66337")] | |||
| public void Diagnostics_Respect_SuppressMessageAttribute() | |||
There was a problem hiding this comment.
Can we get the same tests for VB?
There was a problem hiding this comment.
Didn't notice there are VB tests for this. Added.
chsienki
approved these changes
Feb 23, 2023
333fred
approved these changes
Feb 24, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66337.