Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit MetadataUpdateOriginalTypeAttribute #63169

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Emit MetadataUpdateOriginalTypeAttribute #63169

merged 3 commits into from
Aug 6, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 3, 2022 •
edited
Loading

The attribute, if defined, is emitted into EnC deltas on reloadable types.

Fixes #59954

@tmat tmat requested a review from a team as a code owner August 3, 2022 18:01
@tmat
Copy link
Member Author

tmat commented Aug 3, 2022

@davidwengier @cston @jcouv PTAL

@tmat tmat added this to the 17.4 milestone Aug 3, 2022
@tmat tmat force-pushed the OriginalTypeAttr branch from f77fdcf to 9bf2b85 Compare August 3, 2022 19:22
@runfoapp runfoapp bot mentioned this pull request Aug 3, 2022
Open
jcouv
jcouv approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2) but a couple of questions to clarify or consider

jcouv
jcouv approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@tmat tmat enabled auto-merge (squash) August 4, 2022 16:31
@tmat tmat force-pushed the OriginalTypeAttr branch from 6ca7ef9 to e2541b2 Compare August 6, 2022 01:41
@tmat tmat merged commit 550f811 into dotnet:main Aug 6, 2022
@ghost ghost modified the milestones: 17.4, Next Aug 6, 2022
@tmat tmat mentioned this pull request Aug 8, 2022
Merged
@allisonchou allisonchou mentioned this pull request Aug 16, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an attribute specifying the original type, when we create a diff of a ReloadableType
5 participants
@tmat @davidwengier @cston @jcouv @dibarbet