Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzers to unnecessary nullable directives #62004

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 17, 2022

  • IDE0240: Remove redundant nullable directive (directive has no impact because the state prior to it already matched
  • IDE0241: Remove unnecessary nullable directive (directive reduces nullable analysis scope, but there are no reference types impacted by the scope reduction)
  • Support #nullable restore in each of these diagnostics
  • Add "Remove unnecessary #nullable directives" to Code Clean Up

@sharwell sharwell changed the title Add IDE0240 (Remove redundant nullable directive) Add analyzers to unnecessary nullable directives Jun 17, 2022
@sharwell sharwell force-pushed the unnecessary-directive branch from c548dea to 7f7d1c1 Compare June 20, 2022 18:25
@sharwell sharwell marked this pull request as ready for review June 20, 2022 23:47
@sharwell sharwell requested a review from a team as a code owner June 20, 2022 23:47
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants