Merge main into features/nameof-parameter #60625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial work to move indentation services down to codestyle layer (step 9/N)
…es-in-telemetry-generator-tools
…ted through CodeAction.Create factory methods Fixes dotnet#4919 Currently, we always use the CodeAction's full type name to generate the telemetry ID to log for applied code actions. This is reasonable for special CodeActions that sub-type the CodeAction type and have custom logic. However, majority of fixers and refactorings do not need special CodeAction sub-type and can/should use the CodeAction.Create factory methods to create the code actions to register. Until now, these providers were forced to create a dummy nested type (generally named MyCodeAction) and use it to allow telemetry to capture the outer type's full type name. With this change, we now keep track of whether a CodeAction was created with a factory method or not. If it was created with a factory method, then we use the registering fixer/refactoring provider's full type name for telemetry. Otherwise, we use the CodeAction's full type name. Additionally, we also append the EquivalenceKey in the telemetry ID in both the cases, which should allow multiple code actions registered by the same fixer/refactoring to be differentiated. NOTE: I will create a follow-up PRs in both Roslyn and Roslyn-Analyzers repos to delete all the stub MyCodeAction types once this goes in.
…329.1 (dotnet#60481) [main] Update dependencies from dotnet/arcade
Enable CSharpGoToBase.GoToBaseFromMetadataAsSource
…_switch_enum Inline Diagnostics: Fix conflicting diagnostics and general code cleanup
…ScriptAsynchronousTaggerProvider.cs
… into pauseTaggers
…github.com/DoctorKrolic/roslyn into check-accessibility-in-implement-interface
…eyword Colorize `async` as keyword in some cases
Merge main-vs-deps to main
Change insertion branch
* Implement handling of rename intent * Use documentId instead of URI * Move record definition up top * feedback
Move formatting analyzer to `Analyzers` layer
Add FixAll in containing type/member support for code fixes
AlekseyTs
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.