Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Function Pointer RefKind Display #51223

Merged
merged 12 commits into from
Mar 17, 2021
Merged

Fix Function Pointer RefKind Display #51223

merged 12 commits into from
Mar 17, 2021

Commits on Feb 14, 2021

  1. Fix Function Pointer Display

    @YairHalberstadt
    YairHalberstadt committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    9c99cbc View commit details
    Browse the repository at this point in the history

  2. SignatureOnlyParameterSymbol.ContainingSymbol throws

    @YairHalberstadt
    YairHalberstadt committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    a3f324d View commit details
    Browse the repository at this point in the history

  3. Fix broken test

    @YairHalberstadt
    YairHalberstadt committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    ad7ddea View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Changes based on review by @AlekseyTs and @333fred

    @YairHalberstadt
    YairHalberstadt committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    04b0378 View commit details
    Browse the repository at this point in the history

  2. don't check for function pointer at all in SymbolDisplayVisitor.Visit… 

    …Parameter as they should be handled seperately
    @YairHalberstadt
    YairHalberstadt committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    ef0d6cc View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Fix broken tests, and address feedback from @AlekseyTs

    @YairHalberstadt
    YairHalberstadt committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d31a3dc View commit details
    Browse the repository at this point in the history

  2. check for empty name instead of function pointer symbol in VisitParam… 

    …eter
    @YairHalberstadt
    YairHalberstadt committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    cfbe45c View commit details
    Browse the repository at this point in the history

  3. rename variable from includeOption to includeDefaultValue

    @YairHalberstadt
    YairHalberstadt committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    9799b7d View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. unconditionally display ref kinds for function pointers

    @YairHalberstadt
    YairHalberstadt committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    6f6e883 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Fix couple of broken tests

    @YairHalberstadt
    YairHalberstadt committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e3f11f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/roslyn into fix-func… 

    …tion-pointer-display
    @YairHalberstadt
    YairHalberstadt committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    18f2bde View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Fix tests

    @YairHalberstadt
    YairHalberstadt committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    cb03900 View commit details
    Browse the repository at this point in the history