Fix Metadata as Source caching stale generated files #38064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We maintain a cache of assembly file names and symbols to the generated file. We failed to ever include a version of some kind, so if the metadata file changed on disk, you would continue to get the old generated file.
mavasani
approved these changes
Aug 16, 2019
sharwell
approved these changes
Aug 19, 2019
| @@ -9,6 +13,9 @@ internal class SymbolMappingResult | |||
|
|
|||
| internal SymbolMappingResult(Project project, ISymbol symbol) | |||
| { | |||
| Contract.ThrowIfNull(project); | |||
| Contract.ThrowIfNull(symbol); | |||
There was a problem hiding this comment.
📝 These should be argument validations instead of Contract.ThrowIfNull.
There was a problem hiding this comment.
We'll be converting them all to the new syntax soon enough I suspect...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a cache of assembly file names and symbols to the generated file. We failed to ever include a version of some kind, so if the metadata file changed on disk, you would continue to get the old generated file.
Commit-at-a-time is recommended; I first nullable annotated the feature before doing work in it.