Ensure the caret is visible after commit

[sharwell]

Fixes #33822

[ivanbasov]

1. I tried to repro the integration test. It works without the fix; the caret is visible.
2. I think we need a unit test to prove the need for the fix.

[sharwell]

I tried to repro the integration test. It works without the fix; the caret is visible.

The integration tests default to legacy completion. You need to patch the following line or set an environment variable to enable async completion for integration tests. The bug reproduces 100% of the time with async completion.

roslyn/src/VisualStudio/IntegrationTest/TestUtilities/LegacyCompletionCondition.cs

Line 15 in da920a6

public override bool ShouldSkip => string.Equals(Environment.GetEnvironmentVariable("ROSLYN_TEST_LEGACY_COMPLETION"), "true", StringComparison.OrdinalIgnoreCase);

I think we need a unit test to prove the need for the fix.

The unit test would be inconclusive relative to an integration test. I will file a follow-up item to add a unit test, but the current integration test is a conclusive demonstration of the issue at hang in the context of the Visual Studio product.

[ivanbasov]

I re-evaluated it with the new completion and found the issue. Sorry for confusion!
There is an issue.

The fix is good. I am fine to merge it into master with a follow up issue for a unit test.