Remove fixed IBC drop name #33358
Merged
Remove fixed IBC drop name #33358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonmalinowski FYI: This change shouldn't flow to master. |
|
@tmat Is there something we can do inside of the yaml to condition it based on branch name? Git gives no way to stop this to flow short of Tiger dealing with this manually. Tagging @RikkiGibson and his temporary backup @agocke. |
|
@jasonmalinowski Yes, that sounds better. @jmarolf Should we also make this conditional on branch being built? |
|
@jasonmalinowski Let's use this PR now to get RPS tests. Meanwhile I can prepare another change that selects the branch conditionally. |
jaredpar
reviewed
Feb 13, 2019
azure-pipelines-official.yml
Outdated
| @@ -60,7 +60,7 @@ jobs: | |||
| -officialSkipTests $(SkipTests) | |||
| -officialSkipApplyOptimizationData $(SkipApplyOptimizationData) | |||
| /p:RepositoryName=$(Build.Repository.Name) | |||
| /p:VisualStudioIbcSourceBranchName="master-vs-deps" | |||
| /p:VisualStudioIbcSourceBranchName="dev16.0-vs-deps" | |||
There was a problem hiding this comment.
Won't this evetnually break the YAML file in master when it flows back?
tmat
force-pushed
the
dev/tmat/newibc-d16.0
branch
from
9d4358f to
b62cad4
Compare
tmat
force-pushed
the
dev/tmat/newibc-d16.0
branch
from
b62cad4 to
da90de3
Compare
jaredpar
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause the build to pick up the latest.