Diagnostic Improvements for error #0281#27052

Merged

fayrose merged 23 commits intodotnet:masterfrom fayrose:larose-cs0281

Jun 2, 2018

+221-60

Commits on May 22, 2018

Fixed error 0281 and added test coverage.
Lauren Rosenberg
committed

Commits on May 23, 2018

Indentation fix
Lauren Rosenberg
committed
PublicKeyToString no longer an extension method; fixed diagnose in binder lookup
Lauren Rosenberg
committed
Extracted friendRefNotEqualToThis into local function
Lauren Rosenberg
committed
Fixed usings
Lauren Rosenberg
committed
Double blank line fix for Jared
Lauren Rosenberg
committed
Resctructured diagnose block to increase readability
Lauren Rosenberg
committed
Fixed build errors
Lauren Rosenberg
committed

Commits on May 24, 2018

Requested changes
Lauren Rosenberg
committed
Minor refactoring and fixed return causing incorrect errors
Lauren Rosenberg
committed
Stack overflow fix
Lauren Rosenberg
committed

Commits on May 29, 2018

Fix failing tests to conform to new error
Lauren Rosenberg
committed

Commits on May 30, 2018

All local tests passing
Lauren Rosenberg
committed
Extended new error message to PrivateProtected and InternalProtected
Lauren Rosenberg
committed
PrivateProtected / InternalProtected Test changes
Lauren Rosenberg
committed
Enhanced readability
Lauren Rosenberg
committed
Bizarre rabbithole bug
Lauren Rosenberg
committed

Commits on May 31, 2018

Indent fixes
Lauren Rosenberg
committed

Commits on Jun 1, 2018

Re-added attribute check
Lauren Rosenberg
committed
Restructured to prevent overflow
Lauren Rosenberg
committed
Test fixes
Lauren Rosenberg
committed
Removed Unnecessary changes
Lauren Rosenberg
committed
Oops
Lauren Rosenberg
committed