Properly detect root of a tree in Operation.SearchParentOperation #22974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Area-Compilers
Feature - IOperation
|
@dotnet/roslyn-compiler, @dotnet/analyzer-ioperation, @heejaechang, @cston Please review 15.5 IOperation fix. |
heejaechang
approved these changes
Nov 2, 2017
mavasani
approved these changes
Nov 2, 2017
agocke
reviewed
Nov 2, 2017
| @@ -286,6 +285,12 @@ internal IOperation SearchParentOperation() | |||
| } | |||
| } | |||
|
|
|||
| if (SemanticModel.Root == currentCandidate) | |||
There was a problem hiding this comment.
I believe you could avoid duplicating this check by doing it at the beginning of the loop and setting currentCandidate to Syntax at the beginning of the loop.
There was a problem hiding this comment.
I believe you could avoid duplicating this check by doing it at the beginning of the loop and setting currentCandidate to Syntax at the beginning of the loop.
Then the loop would have to be changed to ```while (true) and the null check moved inside. I believe the condition is simple enough that duplication is not an issue.
|
Pre-Approved to merge via Link |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2017
* dotnet/master: (36 commits) Remove usage of IOperation feature flag in newly added unit tests More fixes for IOperation tree. (dotnet#23028) Address PR feedback and remove unused resource and comment out unused error code Remove IOperation feature flag and internal registration APIs for operations Add unit test for VB Address review feedback and add more unit tests Fix unit tests Fix build errors from merge resolution Revert unintentional newline deletion Address recent feedback and do not generate an IParenthesizedOperation for C#. This change is now just a test-only change that verifies the current behavior. Address PR feedback and use singleton for null instance Address PR feedback Address PR feedback Do not invoke GetStandaloneNode helper in GetOperationWorker Fix InvalidCastException in CSharpOperationFactory for invalid nested member initializer (dotnet#22983) Use ICollection<string>.Contains to avoid Enumerator allocation Add IsRef property to IConditionalOperation and ISimpleAssignmentOperation, add RefKind property to ILocalSymbol. (dotnet#22933) Enable peverify-compat mode for langver < 7.2 (dotnet#22772) Properly detect root of a tree in Operation.SearchParentOperation (dotnet#22974) Fix IArgument and IArrayInitializer to have null types ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22964
vso :https://devdiv.visualstudio.com/DevDiv/NET%20Developer%20Experience%20Productivity/_workitems/edit/518796