Make Fix-All use normal text-diffing as the TreeDiffer produces some very bad results. #17497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very bad results.
…rwrite of existing code.
|
Tagging @dotnet/roslyn-ide |
|
retest windows_debug_unit32_prtest please |
|
retest ubuntu_14_debug_prtest please |
|
retest windows_debug_vs-integration_prtest please |
|
retest windows_release_vs-integration_prtest please |
|
retest ubuntu_16_debug_prtest please |
dpoeschl
approved these changes
Mar 7, 2017
| { | ||
| var overlappingSpans = ArrayBuilder<TextChange>.GetInstance(); | ||
| var intersectingSpans = ArrayBuilder<TextChange>.GetInstance(); | ||
|
|
||
| var result = AllChangesCanBeApplied( |
There was a problem hiding this comment.
I don't like calling things "result", even if it is very temporary.
| } | ||
| else | ||
| var value = ChangeCanBeApplied(change, | ||
| overlappingSpans: overlappingSpans, |
| ArrayBuilder<TextChange> intersectingSpans) | ||
| { | ||
| // Pure insertions (i.e. changes with empty spans) are complex to evaluate. | ||
| // We have to make sure that |
| ArrayBuilder<TextChange> overlappingSpans, | ||
| ArrayBuilder<TextChange> intersectingSpans) | ||
| { | ||
| // Pure insertions (i.e. changes with empty spans) are complex to evaluate. |
There was a problem hiding this comment.
"changes with empty overlapping/intersecting spans" or some other wording?
| // And non-empty spans that we abut (i.e. which we're adjacent to) are totally safe | ||
| // for both to be applied. | ||
| // | ||
| // However, empty-span changes are extremely ambiguous. It is not possible to tell which |
There was a problem hiding this comment.
"empty-span changes" is a weird term. Can you just better define "pure insertion" at the beginning and then rely on that term instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.