Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightBulb Preview buffer leaks via LSP #75492

Open
KirillOsenkov opened this issue Oct 12, 2024 · 3 comments · May be fixed by #75551
Open

LightBulb Preview buffer leaks via LSP #75492

KirillOsenkov opened this issue Oct 12, 2024 · 3 comments · May be fixed by #75551
Assignees
Labels

Comments

@KirillOsenkov
Copy link
Member

When you open a LightBulb preview, DiagnosticsReactingDocumentoperationListener.DocumentOpened is getting called for the buffer that contains the preview text (even two because it's a diff?)

However I'm not seeing the DocumentClosed called for these buffers, which results in a pretty bad memory leak

Image

Image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 12, 2024
@KirillOsenkov
Copy link
Member Author

This is pretty impactful, we're leaking quite a lot on every lightbulb preview invocation.

We should also check other scenarios where we show buffers: Peek, diff, debugger textboxes, output window (?), etc

@dibarbet
Copy link
Member

Had a quick chat with Kayle, we may need to set the content type back to inert to signal features to unhook from it.

@KirillOsenkov
Copy link
Member Author

yup, that should do the trick

@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants