Dispose of ITextDocument(s) when closing preview view #75551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
inert_preview_content
branch
from
785d7f8 to
5c40bed
Compare
dibarbet
changed the title
src/EditorFeatures/Core/Preview/AbstractPreviewFactoryService.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/Preview/AbstractPreviewFactoryService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Oct 17, 2024
src/EditorFeatures/Core/Preview/AbstractPreviewFactoryService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Oct 17, 2024
src/EditorFeatures/Core/Preview/AbstractPreviewFactoryService.cs
Outdated
Show resolved
Hide resolved
|
After talking with Jason/Kayle offline - we decided to go a different route. Now we instead just dispose of the ITextDocument we create (it is IDisposable already, but we weren't disposing). There is a corresponding change on the LSP client side to ensure the diagnostics state is removed - https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/586188 |
|
@dibarbet Don't forget to change the PR title. |
dibarbet
changed the title
CyrusNajmabadi
approved these changes
Oct 18, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75492
Debugged and verified that the language client now unhooks from these buffers.