Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB interfaces not emitted it a deterministic order across partial types #7111

Closed
jaredpar opened this issue Nov 30, 2015 · 0 comments
Closed

VB interfaces not emitted it a deterministic order across partial types #7111

jaredpar opened this issue Nov 30, 2015 · 0 comments
Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
1.2

Comments

@jaredpar
Copy link
Member

Consider the following Code

' file1.vb
Partial Class C 
  Implements I1
End Class

' file2.vb
Partial Class C
  Implements I2
End class

These interfaces should be emitted in source order (irrespective of determinism). At this time they are not.
@jaredpar jaredpar added Bug Area-Compilers Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. labels Nov 30, 2015
@jaredpar jaredpar added this to the 1.2 milestone Nov 30, 2015
@gafter gafter mentioned this issue Nov 30, 2015
Closed
35 tasks
gafter added a commit to gafter/roslyn that referenced this issue Dec 1, 2015
@gafter
Make VB's SyntaxReferences and Locations deterministic
919c411 
Fixes dotnet#7111
Fixes dotnet#7112
gafter added a commit to gafter/roslyn that referenced this issue Dec 1, 2015
@gafter
Partial classes should have their parts produced in source order
bed64ea 
Fixes dotnet#7111
Fixes dotnet#7112
@gafter gafter mentioned this issue Dec 1, 2015
Closed
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Dec 1, 2015
@gafter gafter closed this as completed in 487c201 Dec 4, 2015
@gafter gafter added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Dec 4, 2015
@gafter gafter removed their assignment Dec 4, 2015
@jaredpar jaredpar mentioned this issue Jan 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@jaredpar @gafter