Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test 'InteractiveHostDesktopTests.StackOverflow' #46414

Open
RikkiGibson opened this issue Jul 29, 2020 · 3 comments · May be fixed by #49710
Open

Flaky test 'InteractiveHostDesktopTests.StackOverflow' #46414

RikkiGibson opened this issue Jul 29, 2020 · 3 comments · May be fixed by #49710
Labels
Milestone

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jul 29, 2020

public async Task StackOverflow()

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=749582&view=ms.vss-test-web.build-test-results-tab&runId=23240534&resultId=202015&paneView=debug

Xunit log:

    Microsoft.CodeAnalysis.UnitTests.Interactive.InteractiveHostDesktopTests.StackOverflow [FAIL]
      Assert.Equal() Failure
                                       � (pos 52)
      Expected: úúúckOverflowException.\nHosting process exited with exit code -1úúú
      Actual:   úúúckOverflowException.
                                       � (pos 52)
      Stack Trace:
        /_/src/Interactive/HostTest/InteractiveHostDesktopTests.cs(94,0): at Microsoft.CodeAnalysis.UnitTests.Interactive.InteractiveHostDesktopTests.StackOverflow()
        --- End of stack trace from previous location ---

Runfo Tracking Issue: microsoft.codeanalysis.unittests.interactive.interactivehostdesktoptests.stackoverflow

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@RikkiGibson
Copy link
Contributor Author

Another run containing this failure

https://dev.azure.com/dnceng/public/_build/results?buildId=778472&view=ms.vss-test-web.build-test-results-tab&runId=24376582&resultId=100019&paneView=debug

@tmat would a PR be accepted which accepts either of these strings or perhaps checks a prefix match in the error message?

@tmat
Copy link
Member

tmat commented Aug 19, 2020

Yes, accepting either of these seems a fine workaround. Let's keep an issue opened to track investigation of why are we not seeing the rest of the message. It's not critical though that we do not.

@sharwell sharwell linked a pull request Dec 1, 2020 that will close this issue
@jaredpar
Copy link
Member

Can we please move forward with this change? This test is the #1 most flaky test in Roslyn right now. It's failing at least one build per day.

jaredpar added a commit to jaredpar/roslyn that referenced this issue May 13, 2021
jaredpar added a commit that referenced this issue May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants