Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditAndContinueTests.AnonymousTypes changes emit order in 64-bit runner #223

Closed
agocke opened this issue Feb 4, 2015 · 4 comments · Fixed by #948
Closed

EditAndContinueTests.AnonymousTypes changes emit order in 64-bit runner #223

agocke opened this issue Feb 4, 2015 · 4 comments · Fixed by #948
Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Concept-Portability The issue deals with portable code (portable libraries, etc.). Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Verified
Milestone
1.0-rc2

Comments

@agocke
Copy link
Member

agocke commented Feb 4, 2015

Failure:

Microsoft.CodeAnalysis.VisualBasic.UnitTests.EditAndContinueTests.AnonymousTypes [FAIL]
        Actual:
        <Module>,
        VB$AnonymousType_1`2,
        VB$AnonymousType_2`1,
        VB$AnonymousType_0`2,
        A,
        B
        Differences:
            <Module>,
            VB$AnonymousType_1`2,
        ++> VB$AnonymousType_2`1,
            VB$AnonymousType_0`2,
        Stack Trace:
           src\Test\Utilities\AssertEx.cs(208,0): at Roslyn.Test.Utilities.AssertEx.Equal[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector)
           src\Compilers\VisualBasic\Test\Emit\Emit\EditAndContinueTestBase.vb(212,0): at Microsoft.CodeAnalysis.VisualBasic.UnitTests.EditAndContinueTestBase.CheckNames(MetadataReader[] readers, StringHandle[] handles, String[] expectedNames)
           src\Compilers\VisualBasic\Test\Emit\Emit\EditAndContinueTestBase.vb(207,0): at Microsoft.CodeAnalysis.VisualBasic.UnitTests.EditAndContinueTestBase.CheckNames(MetadataReader reader, StringHandle[] handles, String[] expectedNames)
           src\Compilers\VisualBasic\Test\Emit\Emit\EditAndContinueTests.vb(3328,0): at Microsoft.CodeAnalysis.VisualBasic.UnitTests.EditAndContinueTests.AnonymousTypes()
@tmat
Copy link
Member

tmat commented Feb 4, 2015

Known issue - anonymous types are non-deterministically ordered. The compiler needs to be fixed to order them.

@tmat
Copy link
Member

tmat commented Feb 4, 2015

(the non-determinism is in enumerating dictionary entries)

@gafter gafter self-assigned this Feb 4, 2015
@gafter gafter mentioned this issue Feb 10, 2015
Closed
35 tasks
@gafter gafter added this to the 1.1 milestone Feb 12, 2015
@gafter gafter added 1 - Planning Concept-Portability The issue deals with portable code (portable libraries, etc.). labels Feb 25, 2015
@gafter gafter modified the milestones: 1.0-rc2, 1.1 Feb 27, 2015
gafter added a commit to gafter/roslyn that referenced this issue Feb 27, 2015
@gafter
Emit anonymous types in deterministic order
f9d9bf8 
Fixes dotnet#223
@gafter gafter mentioned this issue Feb 27, 2015
Merged
@gafter gafter added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Feb 27, 2015
@gafter gafter assigned agocke and unassigned gafter Feb 28, 2015
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Feb 28, 2015
@gafter
Copy link
Member

gafter commented Feb 28, 2015

@agocke can you please verify?

@gafter gafter added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. labels Mar 4, 2015
@gafter
Copy link
Member

gafter commented Jun 12, 2015

Verifying that this test is no longer skipped in the stabilization branch.

@agocke agocke removed their assignment Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Concept-Portability The issue deals with portable code (portable libraries, etc.). Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Verified
Projects
None yet
Milestone
1.0-rc2
Development

Successfully merging a pull request may close this issue.

Emit anonymous types in deterministic order gafter/roslyn
3 participants
@tmat @agocke @gafter