Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous types in VB do not include the module name, so cannot be combined into netmodules #1319

Closed
gafter opened this issue Mar 17, 2015 · 4 comments
Closed

Anonymous types in VB do not include the module name, so cannot be combined into netmodules #1319

gafter opened this issue Mar 17, 2015 · 4 comments
Assignees
@gafter
Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Language-VB Resolution-Not Reproducible The described behavior could not be reproduced by developers Verification Not Required
Milestone
1.1

Comments

@gafter
Copy link
Member

gafter commented Mar 17, 2015

See C# test MultipleNetmodulesWithAnonymousTypes

A similar test for VB will likely reveal a problem that needs to be fixed.
@gafter gafter added Bug Language-VB Area-Compilers Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. labels Mar 17, 2015
@gafter gafter self-assigned this Mar 17, 2015
@gafter gafter added this to the 1.0 (stable) milestone Mar 17, 2015
@gafter gafter mentioned this issue Mar 17, 2015
Merged
@gafter gafter modified the milestones: 1.1, 1.0 (stable) Apr 14, 2015
@gafter gafter mentioned this issue Jul 29, 2015
Closed
35 tasks
@jaredpar jaredpar assigned AlekseyTs and unassigned gafter Sep 16, 2015
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Sep 18, 2015
@AlekseyTs
Add regression test for issue dotnet#1319.
b31af68 
Related to dotnet#1319.
@AlekseyTs AlekseyTs mentioned this issue Sep 18, 2015
Merged
@AlekseyTs AlekseyTs added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Sep 18, 2015
AlekseyTs added a commit that referenced this issue Sep 18, 2015
@AlekseyTs
Merge pull request #5332 from AlekseyTs/Issue1319
3f1d36c 
Add regression test for issue #1319.
@AlekseyTs AlekseyTs removed 2 - Ready 4 - In Review A fix for the issue is submitted for review. labels Sep 18, 2015
@AlekseyTs
Copy link
Contributor

It looks like module names are included. I added a unit-test.

@AlekseyTs
Copy link
Contributor

@gafter Please verify.

@AlekseyTs AlekseyTs assigned gafter and unassigned AlekseyTs Sep 18, 2015
@gafter gafter added Resolution-Not Reproducible The described behavior could not be reproduced by developers Verified Verification Not Required and removed Verified labels Sep 20, 2015
@gafter
Copy link
Member Author

gafter commented Sep 20, 2015

You have already verified that the issue had been fixed previously.

@AlekseyTs
Copy link
Contributor

As long as you agree that there is nothing more to fix here. :-) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. Language-VB Resolution-Not Reproducible The described behavior could not be reproduced by developers Verification Not Required
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@gafter @AlekseyTs