Fix race condition in test

dotnet · Nov 14, 2024 · 4e801ee · 4e801ee
1 parent 5a52e85
commit 4e801ee
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Features/TestUtilities/EditAndContinue/EditAndContinueWorkspaceTestBase.cs b/src/Features/TestUtilities/EditAndContinue/EditAndContinueWorkspaceTestBase.cs
@@ -54,13 +54,13 @@ public abstract class EditAndContinueWorkspaceTestBase : TestBase, IDisposable
     /// <summary>
     /// Streams that are verified to be disposed at the end of the debug session (by default).
     /// </summary>
-    public List<(Guid mvid, Stream stream)> DisposalVerifiedStreams = [];
+    private ImmutableList<Stream> _disposalVerifiedStreams = [];
 
     public override void Dispose()
     {
         base.Dispose();
 
-        foreach (var (_, stream) in DisposalVerifiedStreams)
+        foreach (var stream in _disposalVerifiedStreams)
         {
             Assert.False(stream.CanRead);
         }
@@ -314,15 +314,15 @@ internal Guid EmitLibrary(Compilation compilation, DebugInformationFormat pdbFor
             OpenAssemblyStreamImpl = () =>
             {
                 var stream = new MemoryStream();
-                DisposalVerifiedStreams.Add((moduleId, stream));
+                ImmutableInterlocked.Update(ref _disposalVerifiedStreams, s => s.Add(stream));
                 peImage.WriteToStream(stream);
                 stream.Position = 0;
                 return stream;
             },
             OpenPdbStreamImpl = () =>
             {
                 var stream = new MemoryStream();
-                DisposalVerifiedStreams.Add((moduleId, stream));
+                ImmutableInterlocked.Update(ref _disposalVerifiedStreams, s => s.Add(stream));
                 pdbImage.WriteToStream(stream);
                 stream.Position = 0;
                 return stream;