CA1810: Report only if field belongs to ctor's type #5812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5812 +/- ##
==========================================
- Coverage 95.58% 95.57% -0.01%
==========================================
Files 1284 1284
Lines 296834 296866 +32
Branches 18101 18103 +2
==========================================
+ Hits 283725 283738 +13
- Misses 10670 10680 +10
- Partials 2439 2448 +9 |
| { | ||
| static C2() | ||
| { | ||
| C1.Size = 42; |
There was a problem hiding this comment.
What would be the result if the static ctor initializes both static fields of another type and also static fields of the containing type? Would it match our expected result in that case? Can you add a unit test?
There was a problem hiding this comment.
Haven't reviewed the implementation, but need to verify this is truly a false positive. CA1810 is a performance analyzer that I don't believe is enabled by default, so we'll want to make sure the analyzer is fully preserving the original intent after this change. Further discussion will go in #5784.
|
@sharwell Please let me know if you think that's better to close PR. |
|
@Evangelink yep, the analyzer is behaving by design here |
Fix #5784