Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/6.0.1xx-preview4 #5018

Merged

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/6.0.1xx-preview4.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/main-to-release/6.0.1xx-preview4
git reset --hard upstream/release/6.0.1xx-preview4
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/6.0.1xx-preview4 --force

Youssef1313 and others added 30 commits February 9, 2021 15:05
…tCodeQualityAnalyzersResources.resx

Co-authored-by: Sam Harwell <[email protected]>
# Conflicts:
#	src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx
This reverts commit 68b9d1f.
Introduce a base class for globalization analyzers
CA1054 (UriParametersShouldNotBeStrings): better code fix title
Bump code style package to 3.9.0
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #5018 (acf8240) into release/6.0.1xx-preview4 (be17383) will increase coverage by 0.00%.
The diff coverage is 88.30%.

@@                    Coverage Diff                    @@
##           release/6.0.1xx-preview4    #5018   +/-   ##
=========================================================
  Coverage                     95.54%   95.55%           
=========================================================
  Files                          1187     1189    +2     
  Lines                        273034   273040    +6     
  Branches                      16527    16532    +5     
=========================================================
+ Hits                         260875   260893   +18     
+ Misses                         9975     9961   -14     
- Partials                       2184     2186    +2     

@mavasani mavasani merged commit e30830b into release/6.0.1xx-preview4 Apr 14, 2021
@mavasani mavasani deleted the merges/main-to-release/6.0.1xx-preview4 branch April 14, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants