Bump code style package to 3.9.0

.editorconfig

@@ -12,6 +12,11 @@ indent_style = space
 # https://github.com/dotnet/roslyn-analyzers/issues/3389
 dotnet_diagnostic.RS1024.severity = none
 
+# IDE0078: Use pattern matching
+# https://github.com/dotnet/roslyn/issues/51691
+# https://github.com/dotnet/roslyn/issues/51693
+dotnet_diagnostic.IDE0078.severity = silent
+
 # Code files
 [*.{cs,csx,vb,vbx}]
 indent_size = 4

README.md

@@ -160,7 +160,7 @@ See [VERSIONING.md](.//VERSIONING.md) for the versioning scheme for all analyzer
 
 Recommended Analyzer Package Version: [![NuGet](https://img.shields.io/nuget/v/Microsoft.CodeAnalysis.NetAnalyzers.svg)](https://www.nuget.org/packages/Microsoft.CodeAnalysis.NetAnalyzers)
 
-Required Visual Studio Version: **Visual Studio 2019 16.8 RTW or later**
+Required Visual Studio Version: **Visual Studio 2019 16.9 RTW or later**
 
 Required .NET SDK Version: **.NET 5.0 SDK or later**
 

eng/Versions.props

@@ -24,7 +24,7 @@
     <!-- Use the correct compiler version -->
     <UsingToolMicrosoftNetCompilers>true</UsingToolMicrosoftNetCompilers>
     <!-- Dependencies from https://github.com/dotnet/roslyn -->
-    <MicrosoftNETCoreCompilersPackageVersion>3.8.0</MicrosoftNETCoreCompilersPackageVersion>
+    <MicrosoftNETCoreCompilersPackageVersion>3.9.0</MicrosoftNETCoreCompilersPackageVersion>
     <MicrosoftNetCompilersToolsetVersion>$(MicrosoftNETCoreCompilersPackageVersion)</MicrosoftNetCompilersToolsetVersion>
     <CodeStyleAnalyersVersion>$(MicrosoftNETCoreCompilersPackageVersion)</CodeStyleAnalyersVersion>
     <!-- Roslyn -->

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/ClassIsNotDiagnosticAnalyzer.cs

@@ -13,7 +13,7 @@ public sealed class ClassIsNotDiagnosticAnalyzer : DiagnosticAnalyzer
         private static readonly LocalizableString s_localizableTitleNotDiagnosticAnalyzer = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.ClassIsNotDiagnosticAnalyzerTitle), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
         private static readonly LocalizableString s_localizableMessageNotDiagnosticAnalyzer = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.ClassIsNotDiagnosticAnalyzerMessage), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
 
-        public static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor Rule = new(
             DiagnosticIds.TypeIsNotDiagnosticAnalyzerRuleId,
             s_localizableTitleNotDiagnosticAnalyzer,
             s_localizableMessageNotDiagnosticAnalyzer,

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticDescriptorCreationAnalyzer.cs

@@ -171,7 +171,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer : DiagnosticAna
         /// <summary>
         /// RS1031 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.DefineDiagnosticTitleCorrectlyTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor DefineDiagnosticTitleCorrectlyRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor DefineDiagnosticTitleCorrectlyRule = new(
             DiagnosticIds.DefineDiagnosticTitleCorrectlyRuleId,
             s_localizableDefineDiagnosticTitleCorrectlyTitle,
             s_localizableDefineDiagnosticTitleCorrectlyMessage,
@@ -183,7 +183,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer : DiagnosticAna
         /// <summary>
         /// RS1032 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.DefineDiagnosticMessageCorrectlyTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor DefineDiagnosticMessageCorrectlyRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor DefineDiagnosticMessageCorrectlyRule = new(
             DiagnosticIds.DefineDiagnosticMessageCorrectlyRuleId,
             s_localizableDefineDiagnosticMessageCorrectlyTitle,
             s_localizableDefineDiagnosticMessageCorrectlyMessage,
@@ -195,7 +195,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer : DiagnosticAna
         /// <summary>
         /// RS1033 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.DefineDiagnosticDescriptionCorrectlyTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor DefineDiagnosticDescriptionCorrectlyRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor DefineDiagnosticDescriptionCorrectlyRule = new(
             DiagnosticIds.DefineDiagnosticDescriptionCorrectlyRuleId,
             s_localizableDefineDiagnosticDescriptionCorrectlyTitle,
             s_localizableDefineDiagnosticDescriptionCorrectlyMessage,

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticDescriptorCreationAnalyzer_IdRangeAndCategoryValidation.cs

@@ -35,7 +35,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer
         /// <summary>
         /// RS1018 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.DiagnosticIdMustBeInSpecifiedFormatTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor DiagnosticIdMustBeInSpecifiedFormatRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor DiagnosticIdMustBeInSpecifiedFormatRule = new(
             DiagnosticIds.DiagnosticIdMustBeInSpecifiedFormatRuleId,
             s_localizableDiagnosticIdMustBeInSpecifiedFormatTitle,
             s_localizableDiagnosticIdMustBeInSpecifiedFormatMessage,
@@ -48,7 +48,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer
         /// <summary>
         /// RS1020 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.UseCategoriesFromSpecifiedRangeTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor UseCategoriesFromSpecifiedRangeRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor UseCategoriesFromSpecifiedRangeRule = new(
             DiagnosticIds.UseCategoriesFromSpecifiedRangeRuleId,
             s_localizableUseCategoriesFromSpecifiedRangeTitle,
             s_localizableUseCategoriesFromSpecifiedRangeMessage,
@@ -61,7 +61,7 @@ public sealed partial class DiagnosticDescriptorCreationAnalyzer
         /// <summary>
         /// RS1021 (<inheritdoc cref="CodeAnalysisDiagnosticsResources.AnalyzerCategoryAndIdRangeFileInvalidTitle"/>)
         /// </summary>
-        public static readonly DiagnosticDescriptor AnalyzerCategoryAndIdRangeFileInvalidRule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor AnalyzerCategoryAndIdRangeFileInvalidRule = new(
             DiagnosticIds.AnalyzerCategoryAndIdRangeFileInvalidRuleId,
             s_localizableAnalyzerCategoryAndIdRangeFileInvalidTitle,
             s_localizableAnalyzerCategoryAndIdRangeFileInvalidMessage,

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DoNotUseCompilationGetSemanticModelAnalyzer.cs

@@ -16,7 +16,7 @@ public sealed class DoNotUseCompilationGetSemanticModelAnalyzer : DiagnosticAnal
         private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseCompilationGetSemanticModelMessage), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
         private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseCompilationGetSemanticModelDescription), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
 
-        public static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(
+        public static readonly DiagnosticDescriptor Rule = new(
             DiagnosticIds.DoNotUseCompilationGetSemanticModelRuleId,
             s_localizableTitle,
             s_localizableMessage,

src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Fixers/DefineDiagnosticDescriptorArgumentsCorrectlyFix.CustomFixAllProvider.cs

@@ -18,7 +18,7 @@ public sealed partial class DefineDiagnosticDescriptorArgumentsCorrectlyFix : Co
     {
         private sealed class CustomFixAllProvider : FixAllProvider
         {
-            public static CustomFixAllProvider Instance = new CustomFixAllProvider();
+            public static CustomFixAllProvider Instance = new();
 
             private CustomFixAllProvider()
             {

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/IdentifiersShouldHaveCorrectSuffix.cs

@@ -46,27 +46,27 @@ public sealed class IdentifiersShouldHaveCorrectSuffixAnalyzer : DiagnosticAnaly
 
         // Tuple says <TypeInheritedOrImplemented, AppropriateSuffix, Bool value saying if the suffix can `Collection` or the `AppropriateSuffix`>s
         // The bool values are as mentioned in the Uri
-        private static readonly List<(string typeName, string suffix, bool canSuffixBeCollection)> s_baseTypesAndTheirSuffix = new List<(string, string, bool)>()
-                                                    {
-                                                        ("System.Attribute", "Attribute", false),
-                                                        ("System.EventArgs", "EventArgs", false),
-                                                        ("System.Exception", "Exception", false),
-                                                        ("System.Collections.ICollection", "Collection", false),
-                                                        ("System.Collections.IDictionary", "Dictionary", false),
-                                                        ("System.Collections.IEnumerable", "Collection", false),
-                                                        ("System.Collections.Queue", "Queue", true),
-                                                        ("System.Collections.Stack", "Stack", true),
-                                                        ("System.Collections.Generic.Queue`1", "Queue", true),
-                                                        ("System.Collections.Generic.Stack`1", "Stack", true),
-                                                        ("System.Collections.Generic.ICollection`1", "Collection", false),
-                                                        ("System.Collections.Generic.IDictionary`2", "Dictionary", false),
-                                                        ("System.Collections.Generic.IReadOnlyDictionary`2", "Dictionary", false),
-                                                        ("System.Data.DataSet", "DataSet", false),
-                                                        ("System.Data.DataTable", "DataTable", true),
-                                                        ("System.IO.Stream", "Stream", false),
-                                                        ("System.Security.IPermission","Permission", false),
-                                                        ("System.Security.Policy.IMembershipCondition", "Condition", false)
-                                                    };
+        private static readonly List<(string typeName, string suffix, bool canSuffixBeCollection)> s_baseTypesAndTheirSuffix = new()
+        {
+            ("System.Attribute", "Attribute", false),
+            ("System.EventArgs", "EventArgs", false),
+            ("System.Exception", "Exception", false),
+            ("System.Collections.ICollection", "Collection", false),
+            ("System.Collections.IDictionary", "Dictionary", false),
+            ("System.Collections.IEnumerable", "Collection", false),
+            ("System.Collections.Queue", "Queue", true),
+            ("System.Collections.Stack", "Stack", true),
+            ("System.Collections.Generic.Queue`1", "Queue", true),
+            ("System.Collections.Generic.Stack`1", "Stack", true),
+            ("System.Collections.Generic.ICollection`1", "Collection", false),
+            ("System.Collections.Generic.IDictionary`2", "Dictionary", false),
+            ("System.Collections.Generic.IReadOnlyDictionary`2", "Dictionary", false),
+            ("System.Data.DataSet", "DataSet", false),
+            ("System.Data.DataTable", "DataTable", true),
+            ("System.IO.Stream", "Stream", false),
+            ("System.Security.IPermission", "Permission", false),
+            ("System.Security.Policy.IMembershipCondition", "Condition", false)
+        };
 
         public override void Initialize(AnalysisContext context)
         {

src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/CodeMetricsAnalyzer.cs

@@ -285,7 +285,7 @@ static bool isApplicableByDefault(string ruleId, SymbolKind symbolKind)
 
                         CA1505RuleId => 10,
 
-                        CA1506RuleId => symbolKind == SymbolKind.NamedType ? 95 : 40,
+                        CA1506RuleId => symbolKind == SymbolKind.NamedType ? 95 : (uint)40,
 
                         _ => throw new NotImplementedException(),
                     };

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs

@@ -295,7 +295,7 @@ private void AnalyzeOperationBlock(
 
                 return;
 
-                OperationVisitor CreateOperationVisitor(GlobalFlowStateAnalysisContext context) => new OperationVisitor(guardMethods, osPlatformType, context);
+                OperationVisitor CreateOperationVisitor(GlobalFlowStateAnalysisContext context) => new(guardMethods, osPlatformType, context);
 
                 ValueContentAbstractValue GetValueContentValue(IOperation operation)
                 {

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotDisableHttpClientCRLCheck.cs

@@ -85,16 +85,16 @@ internal class DoNotDisableHttpClientCRLCheck : DiagnosticAnalyzer
                 "handler",
                 (IMethodSymbol methodSymbol, PropertySetAbstractValue abstractValue) =>
                 {
-                    return (abstractValue[ServerCertificateValidationCallbackIndex]) switch
+                    return abstractValue[ServerCertificateValidationCallbackIndex] switch
                     {
-                        PropertySetAbstractValueKind.Flagged => (abstractValue[CheckCertificateRevocationListIndex]) switch
+                        PropertySetAbstractValueKind.Flagged => abstractValue[CheckCertificateRevocationListIndex] switch
                         {
                             PropertySetAbstractValueKind.Flagged => HazardousUsageEvaluationResult.Flagged,
                             PropertySetAbstractValueKind.MaybeFlagged => HazardousUsageEvaluationResult.MaybeFlagged,
                             _ => HazardousUsageEvaluationResult.Unflagged,
                         },
 
-                        PropertySetAbstractValueKind.MaybeFlagged => (abstractValue[CheckCertificateRevocationListIndex]) switch
+                        PropertySetAbstractValueKind.MaybeFlagged => abstractValue[CheckCertificateRevocationListIndex] switch
                         {
                             PropertySetAbstractValueKind.Unflagged => HazardousUsageEvaluationResult.Unflagged,
                             _ => HazardousUsageEvaluationResult.MaybeFlagged,

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotInstallRootCert.cs

@@ -54,7 +54,7 @@ public sealed class DoNotInstallRootCert : DiagnosticAnalyzer
 
         private static HazardousUsageEvaluationResult HazardousUsageCallback(IMethodSymbol methodSymbol, PropertySetAbstractValue propertySetAbstractValue)
         {
-            return (propertySetAbstractValue[0]) switch
+            return propertySetAbstractValue[0] switch
             {
                 PropertySetAbstractValueKind.Flagged => HazardousUsageEvaluationResult.Flagged,
 

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseInsecureDeserializerJavascriptSerializerWithSimpleTypeResolver.cs

@@ -56,7 +56,7 @@ internal class DoNotUseInsecureDeserializerJavaScriptSerializerWithSimpleTypeRes
 
         private static HazardousUsageEvaluationResult HazardousUsageCallback(IMethodSymbol methodSymbol, PropertySetAbstractValue propertySetAbstractValue)
         {
-            return (propertySetAbstractValue[0]) switch
+            return propertySetAbstractValue[0] switch
             {
                 PropertySetAbstractValueKind.Flagged => HazardousUsageEvaluationResult.Flagged,
                 PropertySetAbstractValueKind.Unflagged => HazardousUsageEvaluationResult.Unflagged,

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotUseWeakKDFInsufficientIterationCount.cs

@@ -52,7 +52,7 @@ public sealed class DoNotUseWeakKDFInsufficientIterationCount : DiagnosticAnalyz
 
         private static HazardousUsageEvaluationResult HazardousUsageCallback(IMethodSymbol methodSymbol, PropertySetAbstractValue propertySetAbstractValue)
         {
-            return (propertySetAbstractValue[0]) switch
+            return propertySetAbstractValue[0] switch
             {
                 PropertySetAbstractValueKind.Flagged => HazardousUsageEvaluationResult.Flagged,
 

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/UseSecureCookiesASPNetCore.cs

@@ -59,7 +59,7 @@ public sealed class UseSecureCookiesASPNetCore : DiagnosticAnalyzer
 
         private static HazardousUsageEvaluationResult HazardousUsageCallback(IMethodSymbol methodSymbol, PropertySetAbstractValue propertySetAbstractValue)
         {
-            return (propertySetAbstractValue[0]) switch
+            return propertySetAbstractValue[0] switch
             {
                 PropertySetAbstractValueKind.Flagged => HazardousUsageEvaluationResult.Flagged,
 

src/Roslyn.Diagnostics.Analyzers/CSharp/CSharpSpecializedEnumerableCreationAnalyzer.cs

@@ -64,7 +64,7 @@ public void AnalyzeNode(SyntaxNodeAnalysisContext context)
 
             private bool ShouldAnalyzeExpression(SyntaxNode expression, SemanticModel semanticModel, CancellationToken cancellationToken)
             {
-                return (expression.Kind()) switch
+                return expression.Kind() switch
                 {
                     SyntaxKind.ArrayCreationExpression
                     or SyntaxKind.ImplicitArrayCreationExpression => ShouldAnalyzeArrayCreationExpression(expression, semanticModel, cancellationToken),

src/Text.Analyzers/Core/IdentifiersShouldBeSpelledCorrectly.cs

@@ -43,8 +43,8 @@ public sealed class IdentifiersShouldBeSpelledCorrectlyAnalyzer : DiagnosticAnal
         private static readonly LocalizableString s_localizableMessageMethodTypeParameterMoreMeaningfulName = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyMessageMethodTypeParameterMoreMeaningfulName), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources));
         private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyDescription), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources));
 
-        private static readonly SourceTextValueProvider<CodeAnalysisDictionary> s_xmlDictionaryProvider = new SourceTextValueProvider<CodeAnalysisDictionary>(ParseXmlDictionary);
-        private static readonly SourceTextValueProvider<CodeAnalysisDictionary> s_dicDictionaryProvider = new SourceTextValueProvider<CodeAnalysisDictionary>(ParseDicDictionary);
+        private static readonly SourceTextValueProvider<CodeAnalysisDictionary> s_xmlDictionaryProvider = new(ParseXmlDictionary);
+        private static readonly SourceTextValueProvider<CodeAnalysisDictionary> s_dicDictionaryProvider = new(ParseDicDictionary);
         private static readonly CodeAnalysisDictionary s_mainDictionary = GetMainDictionary();
 
         internal static DiagnosticDescriptor FileParseRule = DiagnosticDescriptorHelper.Create(