Reduce allocations #4892
Merged
Reduce allocations #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
reviewed
Feb 23, 2021
genlu
reviewed
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #4892 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.02%
==========================================
Files 1183 1184 +1
Lines 270513 270536 +23
Branches 16334 16341 +7
==========================================
- Hits 258763 258744 -19
- Misses 9653 9673 +20
- Partials 2097 2119 +22 |
sharwell
force-pushed
the
reduce-allocs
branch
from
e1e47c9 to
2741c0a
Compare
genlu
reviewed
Feb 23, 2021
sharwell
commented
Feb 23, 2021
Comment on lines
+12
to
+13
| <!-- Work around PerformanceSensitiveAttribute.cs cannot resolve ValueTask<TResult>. --> | ||
| <NoWarn>$(NoWarn);CS1574</NoWarn> |
There was a problem hiding this comment.
📝 Submitted #4895 as a draft to remove all these as soon as this PR is published
genlu
approved these changes
Feb 23, 2021
sharwell
commented
Feb 25, 2021
| } | ||
|
|
||
| PostProcessArgument(argumentOperation, isEscaped); | ||
| _pendingArgumentsToPostProcess.Remove(argumentOperation); |
There was a problem hiding this comment.
@mavasani In order to use the ExtractAll method (which has clear semantics), I needed to hoist this call to Remove outside the foreach (where it combined with the Where method). Considering there is no other code that checks _pendingArgumentsToPostProcess.Contains, it seemed like a safe change.
mavasani
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce hot path allocations.
Fixes #4893