Indicate that info-level messages can remain #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NewellClark If you could review this as well, I'd appreciate it. Does this make the definition of done more clear regarding info-level messages? |
NewellClark
approved these changes
Feb 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #4790 +/- ##
==========================================
- Coverage 95.69% 95.68% -0.01%
==========================================
Files 1197 1197
Lines 271784 271784
Branches 16433 16433
==========================================
- Hits 260082 260068 -14
Misses 9599 9599
- Partials 2103 2117 +14 |
mavasani
approved these changes
Feb 6, 2021
buyaa-n
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this discussion, it could be helpful to call out that we don't expect all info-level messages be resolved as part of the Definition of Done for libraries analyzers.