Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to release/6.0.1xx-preview1 #4686

Merged

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from master into release/6.0.1xx-preview1.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-release/6.0.1xx-preview1
git reset --hard upstream/release/6.0.1xx-preview1
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-release/6.0.1xx-preview1 --force

Evangelink and others added 12 commits December 20, 2020 23:20
…/SecurityDiagnosticHelpers.cs

Co-authored-by: Paul Ming <[email protected]>
…ecutionAnalyzer

Rewrite DoNotUseInsecureXSLTScriptExecutionAnalyzer
…ster

# Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
#	src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotUseInsecureXSLTScriptExecution.cs
#	src/NetAnalyzers/UnitTests/Microsoft.NetFramework.Analyzers/DoNotUseInsecureXSLTScriptExecutionXslCompiledTransformLoadInsecureConstructedSettingsTests.cs
#	src/NetAnalyzers/UnitTests/Microsoft.NetFramework.Analyzers/DoNotUseInsecureXSLTScriptExecutionXslCompiledTransformLoadInsecureInputSettingsTests.cs
#	src/NetAnalyzers/VisualBasic/Microsoft.NetFramework.Analyzers/BasicDoNotUseInsecureXSLTScriptExecution.vb
…eInsecureXSLTScriptExecution.cs

Co-authored-by: Paul Ming <[email protected]>
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #4686 (049c59c) into release/6.0.1xx-preview1 (87cb749) will decrease coverage by 0.05%.
The diff coverage is 76.64%.

@@                     Coverage Diff                      @@
##           release/6.0.1xx-preview1    #4686      +/-   ##
============================================================
- Coverage                     95.77%   95.71%   -0.06%     
============================================================
  Files                          1183     1181       -2     
  Lines                        267883   267872      -11     
  Branches                      16177    16195      +18     
============================================================
- Hits                         256555   256399     -156     
- Misses                         9224     9377     +153     
+ Partials                       2104     2096       -8     

@mavasani mavasani merged commit 1691413 into release/6.0.1xx-preview1 Jan 12, 2021
@mavasani mavasani deleted the merges/master-to-release/6.0.1xx-preview1 branch January 12, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants