Fixes for CA1801 (ReviewUnusedParameters) #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
commented
Jun 26, 2019
| { | ||
| return; | ||
| } | ||
|
|
||
| // We only care about methods with parameters. |
There was a problem hiding this comment.
The code here just refactored into a separate static method
|
Thanks @dotpaul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
97d6b44: Bail out on discard symbol names.
Fixes CA1801 in Azure Functions where attribute is needed, but parameter is not #2589
Fixes CA1801 is reported for event-handler method #2593
Fixes CA1801 shouldn't fire for generic functions with inferred-type parameters #2465
Fixes Do not fire CA1801 on lone parameter of struct constructor #1359
9255c80: Analyze local function parameters.
Fixes CA1801 doesn't fire for local functions #2466