-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit all fixers in repo for missing FixAll support and add unit tests #1382
Comments
Tagging @jinujoseph @kuhlenh |
StyleCop Analyzers runs a Fix All test automatically for every code fix test. |
We should do that too.. |
Found one more: #1395 At this point, I am going to write an analyzer to warn when a CodeFixer does not override GetFixAllProvider. |
@mavasani Consider an exception if the analyzer has |
@sharwell I was planning to write an operation analyzer that fires if the fixer invokes RegisterCodeFix (or related) method, but does not override GetFixAllProvider. |
…d to FixAll in fixers Addresses part of dotnet#1382
Audit is done, we have an analyzer to detect missing FixAll support and #1420 tracks adding unit tests. |
I found 2 cases where we have a code fix, but no FixAll support: #1380 and #1381. Additionally there are no FixAll unit tests in our repo. @ivanbasov is planning to add some FixAll test infrastructure support, and we should use that to ensure that we have FixAll tests for every single code fix that we ship.
The text was updated successfully, but these errors were encountered: