Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all fixers in repo for missing FixAll support and add unit tests #1382

Closed
mavasani opened this issue Nov 17, 2017 · 8 comments
Closed
Assignees
Labels
Bug The product is not behaving according to its current intended design Urgency-Soon
Milestone

Comments

@mavasani
Copy link
Contributor

mavasani commented Nov 17, 2017

I found 2 cases where we have a code fix, but no FixAll support: #1380 and #1381. Additionally there are no FixAll unit tests in our repo. @ivanbasov is planning to add some FixAll test infrastructure support, and we should use that to ensure that we have FixAll tests for every single code fix that we ship.

@mavasani mavasani added the Bug The product is not behaving according to its current intended design label Nov 17, 2017
@mavasani mavasani added this to the 15.5.Later milestone Nov 17, 2017
@mavasani
Copy link
Contributor Author

Tagging @jinujoseph @kuhlenh

@sharwell
Copy link
Member

StyleCop Analyzers runs a Fix All test automatically for every code fix test.

@mavasani
Copy link
Contributor Author

StyleCop Analyzers runs a Fix All test automatically for every code fix test.

We should do that too..

@mavasani
Copy link
Contributor Author

Found one more: #1395

At this point, I am going to write an analyzer to warn when a CodeFixer does not override GetFixAllProvider.

@sharwell
Copy link
Member

sharwell commented Nov 22, 2017

@mavasani Consider an exception if the analyzer has NoCodeFixAttribute applied to it.

@mavasani
Copy link
Contributor Author

@sharwell I was planning to write an operation analyzer that fires if the fixer invokes RegisterCodeFix (or related) method, but does not override GetFixAllProvider.

@mavasani
Copy link
Contributor Author

Audit is done, we have an analyzer to detect missing FixAll support and #1420 tracks adding unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The product is not behaving according to its current intended design Urgency-Soon
Projects
None yet
Development

No branches or pull requests

3 participants