Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light up the NuGet packages on GitHub #830

Merged
merged 3 commits into from
Oct 16, 2018
Merged

light up the NuGet packages on GitHub #830

merged 3 commits into from
Oct 16, 2018

Conversation

shiftkey
Copy link
Contributor

@shiftkey shiftkey commented Oct 16, 2018

You might have noticed this announcement about adding support for NuGet packages to GitHub's security vulnerability alerts.

I tested out Octokit.net today and noticed this, and got a bit sad:

Nevermind, it's easy to fix - if the PackageProjectUrl or RepositoryUrl attributes point to a GitHub repository URL (we're not following redirects, ain't nobody got time for that), these will light up differently:

This sadly won't be backported to the old nuspecs unless they get updated, but anyone using System.Reactive currently will get the benefit after a package update.

I'm not sure how attached to fwlinks you are these days, so RepositoryUrl might be the necessary workaroudn here if you want to keep them Just In Case™.

@clairernovotny clairernovotny merged commit b7ea7a2 into dotnet:master Oct 16, 2018
@clairernovotny
Copy link
Member

I wonder how many Microsoft packages have fwlinks? It may be worth finding out and supporting a redirect if it's going to cut-out a lot of packages.

@shiftkey shiftkey deleted the patch-1 branch October 16, 2018 19:27
@shiftkey
Copy link
Contributor Author

@onovotny I'll check in with the team after Universe is done and see if they can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants