light up the NuGet packages on GitHub #830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might have noticed this announcement about adding support for NuGet packages to GitHub's security vulnerability alerts.
I tested out Octokit.net today and noticed this, and got a bit sad:
Nevermind, it's easy to fix - if the
PackageProjectUrl
orRepositoryUrl
attributes point to a GitHub repository URL (we're not following redirects, ain't nobody got time for that), these will light up differently:This sadly won't be backported to the old nuspecs unless they get updated, but anyone using
System.Reactive
currently will get the benefit after a package update.I'm not sure how attached to
fwlink
s you are these days, soRepositoryUrl
might be the necessary workaroudn here if you want to keep them Just In Case™.