-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added debugger display information to TestScheduler and HistoricalScheduler #809
Added debugger display information to TestScheduler and HistoricalScheduler #809
Conversation
@paulomorgado Nice idea. I wonder whether we want to have this for even more classes, e.g. all the observable implementations. I'm thinking outputting a readable representation of an operator chain. Then again, it might slow down the debugger big time...what do you think? |
It might, but only when evaluated. But, for that use case, a debug visualizer might be a better match. What do you think, @raffaeler? |
It may be great for some cases however at least in my projects I my experience is a really bad Vs behaviour when property evaluation is on. Consider making a switch off for this as well. |
How would I do this, @apobekiaris? |
Sorry no clue it just looked something that may affect me. |
@paulomorgado nice work and great idea indeed. |
ETW-like tracing would be nice, but that's another thing. If I recall it correctly, debug visualizations are part of the type/object and debug vizualizers can be an add-on used only by the IDE and that it's not deployed with the library (like analyzers). |
Nevertheless, if anyone has suggestions for other types that would be nice to add debug vizualizers, I can add them. |
@paulomorgado There's actually great potential in this approach I think. As you might know, we would like to optimize some code away but can't because RxSpy, an inspection tool for Rx, depends on certain internals. RxSpy is not in active development and it's unclear to me how widespread its use is. A great deal of its functionality could maybe be replaced by visualizers...maybe....I'm just being visonary here. |
@paulomorgado I did not mean to replace ETW tracing. |
@raffaeler, I said ETW-like because .NET Core on non-Windows system doesn't exactly use ETW. Does it? |
@paulomorgado The abstraction provided in aspnet core is the same for Windows and Linux. On Windows ETW is used. On Linux the abstraction uses LTTNG which is the 'official' way to trace. |
@paulomorgado We have failing approval tests due to the added attributes on some types. Could you please fix them? I'll merge this PR then, more work on a smoother debugging experience is greatly appreciated! |
e17556e
to
72c3b7d
Compare
Done, @danielcweber! |
This is very helpful when debugging tests.