Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review TaskObservableExtensions #760

Merged
merged 8 commits into from
Jul 4, 2018
Merged

Review TaskObservableExtensions #760

merged 8 commits into from
Jul 4, 2018

Commits on Jul 4, 2018

  1. Save the allocation of a closure and allow delegate caching in ToObse… 

    …rvableSlow.
    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    e6e0f95 View commit details
    Browse the repository at this point in the history

  2. Internal shortcut for Task.ToObservable().Subscribe(...). This avoids… 

    … the allocation of an AsyncSubject.
    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    438cd71 View commit details
    Browse the repository at this point in the history

  3. Use new internal Subscribe-shortcut for tasks.

    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    303fbbe View commit details
    Browse the repository at this point in the history

  4. Inline ToObservableSlow, closures are not an issue anymore.

    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    ca73625 View commit details
    Browse the repository at this point in the history

  5. Rename ToObservableDone to EmitTaskResult because ToObservableDone is… 

    … simply not what it's doing...
    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    2479b9a View commit details
    Browse the repository at this point in the history

  6. Make EmitTaskResult an extension method.

    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    ad703e9 View commit details
    Browse the repository at this point in the history

  7. Make ToObservableResult an extension method.

    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    085e9e7 View commit details
    Browse the repository at this point in the history

  8. Simplify ToObservableImpl, that also makes it provable that we never … 

    …return null.
    @danielcweber
    danielcweber committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    28f51f6 View commit details
    Browse the repository at this point in the history