4.x: Improve the performance of ToObservable() #705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance and allocation behavior of the
ToObservable(IEnumerable)
operator by inlining the recursive scheduling management and splits the operator into separate, dedicated long-running and recursive variants.The recursive variant is still declared to not link up the disposable management so the
volatile bool _disposed
field is enough to signal cancellation. In addition, the previousAction<Action<>>
-based recursive scheduling was mostly responsible for the overhead as it was still tracking each recursively scheduled task despite they would have never gotten disposed.Comparison: