Review GroupJoin #648
Merged
Review GroupJoin #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Jun 26, 2018
| var leftSubscription = new SingleAssignmentDisposable(); | ||
| _group.Add(leftSubscription); | ||
| var leftObserver = new LeftObserver(this); | ||
| _group.Add(leftObserver); | ||
| _leftID = 0; |
There was a problem hiding this comment.
No reason to init to default
| var rightSubscription = new SingleAssignmentDisposable(); | ||
| _group.Add(rightSubscription); | ||
| var rightObserver = new RightObserver(this); | ||
| _group.Add(rightObserver); | ||
| _rightID = 0; |
There was a problem hiding this comment.
No reason to initi to default.
| @@ -34,8 +34,8 @@ internal sealed class _ : IdentitySink<TResult> | |||
| private readonly object _gate = new object(); | |||
| private readonly CompositeDisposable _group = new CompositeDisposable(); | |||
| private readonly RefCountDisposable _refCount; | |||
| private readonly SortedDictionary<int, IObserver<TRight>> _leftMap = new SortedDictionary<int, IObserver<TRight>>(); | |||
| private readonly SortedDictionary<int, TRight> _rightMap = new SortedDictionary<int, TRight>(); | |||
| private readonly SortedDictionary<int, IObserver<TRight>> _leftMap; | |||
There was a problem hiding this comment.
How was the original even compiling without an error? You can assign a readonly field twice in C#?
There was a problem hiding this comment.
As long as the assignment is done in the constructor, it's valid. And although it's probably never the developer's intention, it doesn't produce a warning. I assume this is due to possible side effects that the initialization could have.
akarnokd
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We save some allocations by using the same techniques as in earlier PRs.