Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Throttle, save some allocations. #638

Merged
merged 6 commits into from
Jun 26, 2018
Merged

Review Throttle, save some allocations. #638

merged 6 commits into from
Jun 26, 2018

Commits on Jun 25, 2018

  1. Don't override Run, the base methode will handle it.

    @danielcweber
    danielcweber committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    74d5686 View commit details
    Browse the repository at this point in the history

  2. Save closure allocation and allow delegate caching.

    @danielcweber
    danielcweber committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    0fceacf View commit details
    Browse the repository at this point in the history

  3. Save the allocation of a SingleAssignmentDisposable in OnNext. It's p… 

    …urpose is only to dispose of the currently scheduled timer early. We can do that with another call to TrySetSerial, passing null.
    @danielcweber
    danielcweber committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    2c8c0fa View commit details
    Browse the repository at this point in the history

  4. Don't override Run, the base implementation has it covered.

    @danielcweber
    danielcweber committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    0c1dd0c View commit details
    Browse the repository at this point in the history

  5. Let ThrottleObserver inherit from SafeObserver so it can hold onto it… 

    …s own subscription, saving the allocation of a SingleAssignmentDisposable.
    @danielcweber
    danielcweber committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    e17a553 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. Merge branch 'master' into ReworkThrottle

    @danielcweber
    danielcweber authored Jun 26, 2018
    Configuration menu
    Copy the full SHA
    5a64c3e View commit details
    Browse the repository at this point in the history