Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PriorityQueue fix #569

Merged
merged 3 commits into from
Jun 11, 2018
Merged

PriorityQueue fix #569

merged 3 commits into from
Jun 11, 2018

Conversation

danielcweber
Copy link
Collaborator

Repro of a bug in PriorityQueue and @astrofishgames fix as in #329.

akarnokd
akarnokd approved these changes Jun 4, 2018
View reviewed changes
Copy link
Collaborator

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add two more test based on this and this to make sure the basic functionality is verified.

@danielcweber
Copy link
Collaborator Author

If that was clear at all...for the repro, I just assumed the queue is supposed to keep an ordered list and rearrange it on the fly...

@danielcweber
Copy link
Collaborator Author

@akarnokd Two basic tests were added.

@danielcweber danielcweber changed the title Priority queue fix PriorityQueue fix Jun 4, 2018
@danielcweber danielcweber merged commit 52b4668 into dotnet:master Jun 11, 2018
@danielcweber danielcweber deleted the PriorityQueueFix branch June 11, 2018 14:38
@akarnokd akarnokd mentioned this pull request Jun 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielcweber @akarnokd @astrofishgames