4.x: Rework & fix SkipUntil with lock-free methods #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweber
reviewed
Jun 1, 2018
| { | ||
| if (_forward) | ||
| _parent.ForwardOnNext(value); | ||
| if (Interlocked.CompareExchange(ref _halfSerializer, 1, 0) == 0) |
There was a problem hiding this comment.
Would Interlocked.Increment work as well?
There was a problem hiding this comment.
Interlocked has to force a new value so it is more expensive in contended cases whereas CAS is generally cheaper, especially on the weaker platforms where increment may be actually implemented as a CAS loop. Here, there is no need to loop.
danielcweber
approved these changes
Jun 1, 2018
|
Merging, I would really like to see that halfserializer-pattern generalized (static methods etc) |
|
I'll post a PR with additional toolsets. |
danielcweber
reviewed
Jun 1, 2018
| sourceSubscription, | ||
| otherSubscription | ||
| ); | ||
| Disposable.TrySetSingle(ref _otherDisposable, parent._other.Subscribe(new OtherObserver(this))); |
There was a problem hiding this comment.
Sorry, I missed those before merging, this will for now but it should probably be SetSingle (i.e. throw when already set).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the
SkipUntiloperator to use lock-free methods and also fixes a potential race condition with the original setup when both observables signalOnErrorconcurrently.