4.x: Rework TakeUntil with lock-free methods #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| else | ||
| ForwardOnNext(value); | ||
| if (Interlocked.Decrement(ref halfSerializer) != 0) |
There was a problem hiding this comment.
What's that halfSerializer for ?
There was a problem hiding this comment.
Mutually excludes the call to OnNext with any calls to OnError or OnCompleted, deferring them after the OnNext returns.
|
You mind if I try to tidy this up a bit and send you a PR? |
|
Tidy up how? |
|
Stylistically and less noise. I'll make a try and we can discuss. |
| @@ -24,131 +25,118 @@ public TakeUntil(IObservable<TSource> source, IObservable<TOther> other) | |||
|
|
|||
| internal sealed class _ : IdentitySink<TSource> | |||
| { | |||
| private readonly OtherObserver _other; | |||
There was a problem hiding this comment.
Field can be omitted, good to be merged otherwise.
danielcweber
approved these changes
May 30, 2018
danielcweber
approved these changes
May 30, 2018
This was referenced Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal logic of the
TakeUntilto use a lock-free signalling algorithm for all event types.