4.x: Fix XML document spelling errors #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
commented
May 28, 2018
| @@ -53,8 +53,22 @@ | |||
| <ItemGroup> | |||
| <None Update="Linq\Observable\CombineLatest.Generated.tt" Generator="TextTemplatingFileGenerator" LastGenOutput="CombineLatest.Generated.cs" /> | |||
| <Compile Update="Linq\Observable\CombineLatest.Generated.cs" DesignTime="True" AutoGen="True" DependentUpon="CombineLatest.Generated.tt" /> | |||
| <Compile Update="Strings_Linq.Designer.cs"> | |||
There was a problem hiding this comment.
Not sure how this ended up here.
There was a problem hiding this comment.
Probably due to changed master. Rebase, I'll merge.
There was a problem hiding this comment.
I started fresh with this, the update button is greyed out. I'll undo this change.
|
Maybe because I touched those resx files, VS thought why not mess up the project settings with all sorts of different tool versions. |
|
Is it good to merge then? |
|
it passed, so yes. |
| @@ -71,7 +71,7 @@ internal class Strings_Core { | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Looks up a localized string similar to OnCompleted notification doesn't have a value.. | |||
| /// Looks up a localized string similar to OnCompleted notification doesn't have a value.. | |||
There was a problem hiding this comment.
I guess this typo is by design and will be regenerated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of spelling errors in the XML documentation of the public API and then some.
I have left alone the
cancellableand similar worlds because of the US/UK spelling style differences (and somehow the double L comes more natural to me despite the rules).