Reduce allocations for anonymous observables #517
Conversation
| d.Disposable = m; | ||
|
|
||
| m.Disposable = scheduler.Schedule(() => | ||
| return AnonymousObservable<TSource>.CreateStateful( |
There was a problem hiding this comment.
How about not using a delegate either but extending some base class?
There was a problem hiding this comment.
All this can be considered, but it would make review and merging at this point even more complicated. Instead I tried to keep replacements straightforward and easy to review.
There was a problem hiding this comment.
I guess in the end, there will be no justification to use AnonymousObservable from inside Rx any more.
There was a problem hiding this comment.
It is possible that this or some other class will be re-optimized in the future, depending on how the project leads decide upon critical components, which would lead to wasted "small step changes" on our parts. Just say'n.
There was a problem hiding this comment.
AnonymousX in Rx were a workaround because C# still doesn't support anonymous inner classes like Java does and the devs wasn't apparently very keen on just defining new dedicated classes.
There was a problem hiding this comment.
Just say'n.
Don't really know what that's supposed to mean again. Try to encourage people for a change.
…Action<TState> and pass a corresponding state object. The ability to pass state will greatly help to reduce the allocations of closures.
…meter to the subscription function. This will allow the avoidance of closure allocations and enable more delegate caching where AnonymousObservables are created.
… function at various places, resulting in some good savings on closure allocations and delegate caching everywhere!
|
Overridden by #549 if revised and approved. |
|
Obsoleted by #549. |
Almost every use of AnonymousObservable captures some variables in a closure and creates a delegate. This PR works around that by passing state.
Note: This is based on #515 and #518. These should be merged before this PR.