Allow opt-out from TaskScheduler.UnobservedExceptions #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e swallowed Added tests verifying that the old behaviour continues to be the default, and that the new overloads provide the new behaviour when asked for it. (The tests for the latter fail right now because we've not actually changed the implementation yet. Also, the Qbservable API parity tests also fail because we've not yet updated the homoiconicity support to match the new surface area.)
|
It's a pity that the default setting is exactly what most people don't want, but I understand your sentiment about backwards compatibility. |
|
Went with #1914 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: we are more likely to go with #1914 instead now. A problem with the approach in this PR is that it creates additional opportunities for overload resolution ambiguity, so although this is a binary-compatible change, it might cause build errors when people upgrade.
Resolves #1256
Various Rx operators and extension methods can wrap a
Taskas anIObservable<T>. Historically, if you unsubscribe before the task is finished and the task subsequently fails, the resulting exception pops out throughTaskScheduler.UnobservedException.There is a point of view that this is inconsistent with how we cope with exceptions in things like
Selectprojection callbacks that occur after unsubscription - those are just swallowed.This PR provides the ability to ask for these kinds of orphaned exceptions to be ignored when they occur in tasks, just like they are in other scenarios.
The default behaviour does not change because that would break applications depending on the
UnobservedExceptionevent. This adds new overloads enabling opting out.