Add lazy RefCount operator for IObservables. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweber
added a commit
to ExRam/ExRam.Extensions
that referenced
this pull request
Sep 14, 2015
…pefully equivalent to my pull request to Rx.net (dotnet/reactive#133). Once this is merged, this implementation will be removed.
|
How about just adding a |
|
I'm ok with that. Having an overload instead of a new operator would reflect the sanity of the idea even more and show that this is indeed useful. Shall I change it now? |
|
👍 to an overload on |
|
Would it also make sense to reuse the implementation? The classic operator would then just call the new overload passing |
danielcweber
changed the title
akarnokd
reviewed
May 26, 2018
| if (parent._connectableSubscription == null) | ||
| parent._connectableSubscription = parent._source.Connect(); | ||
|
|
||
| parent._serial.Disposable = new SingleAssignmentDisposable(); |
There was a problem hiding this comment.
I'd move this earlier so that the timeout task is cancelled as soon as possible.
akarnokd
reviewed
May 26, 2018
quinmars
reviewed
Jun 3, 2018
… like RefCount but may delay disconnection. This is useful whenever a lot of connect/disconnect cycles are expected within a short timespan but with a significant overhead in connecting/disconnecting. Some unit tests have been added. Lazy RefCount has been excluded from methods that must be present for Qbservable as well. I leave it up to others to decide what Lazy RefCount means for Qbservable and whether there should be an implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LazyRefCount connects like RefCount but may delay disconnection. This is useful whenever a lot of connect/disconnect cycles are expected within a short timespan but with a significant overhead in connecting/disconnecting.
This change is