Skip to content

Commit

Permalink
Merge pull request #799 from dotnet/build
Browse files Browse the repository at this point in the history
Build updates
  • Loading branch information
Oren Novotny authored Aug 3, 2018
2 parents e53a503 + f19afc1 commit 7e2323f
Show file tree
Hide file tree
Showing 12 changed files with 39 additions and 63 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Ix.NET/Layout
Ix.NET/Layout
Rx.NET/Layout


Expand All @@ -15,6 +16,8 @@ local.properties
.classpath
.settings/
.loadpath
*.exe
.store/

*.binlog

Expand Down
1 change: 1 addition & 0 deletions .vsts.ix-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ trigger:
queue: Hosted VS2017
variables:
BuildConfiguration: Release
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

steps:
- template: .vsts.ix-shared.yml
Expand Down
1 change: 1 addition & 0 deletions .vsts.ix-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ trigger: none
queue: Hosted VS2017
variables:
BuildConfiguration: Release
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

steps:
- template: .vsts.ix-shared.yml
22 changes: 13 additions & 9 deletions .vsts.ix-shared.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,21 @@ parameters:
signStep: []

steps:
- task: DotNetCoreInstaller@0
- task: DotNetCoreCLI@2
inputs:
version: '2.1.400-preview-009171'
command: custom
custom: tool
arguments: install --tool-path . nbgv
displayName: Install NBGV tool
condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false))

- task: DotNetCoreCLI@2
inputs:
command: build
projects: Ix.NET/Source/build/setversion.csproj
arguments: -c $(BuildConfiguration)
- script: nbgv cloud -p Ix.NET\Source
displayName: Set Version
condition: eq(variables['system.pullrequest.isfork'], false)
condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false))

- task: DotNetCoreInstaller@0
inputs:
version: '2.1.400-preview-009171'

- task: DotNetCoreCLI@2
inputs:
Expand All @@ -27,7 +31,7 @@ steps:
inputs:
command: test
projects: Ix.NET/Source/**/*.Tests.csproj
arguments: -c $(BuildConfiguration) --collect:"Code Coverage" -s $(System.DefaultWorkingDirectory)/Ix.NET/Source/CodeCoverage.runsettings /p:DebugType=portable
arguments: -c $(BuildConfiguration) --collect:"Code Coverage" -s $(System.DefaultWorkingDirectory)/Ix.NET/Source/CodeCoverage.runsettings /p:DebugType=Full
displayName: Run Tests

- ${{ parameters.signStep }}
Expand Down
1 change: 1 addition & 0 deletions .vsts.rx-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ queue: Hosted VS2017
variables:
BuildConfiguration: Release
BuildPlatform: Any CPU
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

steps:
- template: .vsts.rx-shared.yml
Expand Down
1 change: 1 addition & 0 deletions .vsts.rx-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ queue: Hosted VS2017
variables:
BuildConfiguration: Release
BuildPlatform: Any CPU
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

steps:
- template: .vsts.rx-shared.yml
39 changes: 18 additions & 21 deletions .vsts.rx-shared.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,27 @@ parameters:
signStep: []

steps:
- task: DotNetCoreInstaller@0
inputs:
version: '2.1.400-preview-009171'

- task: NuGetToolInstaller@0
displayName: Use NuGet 4.7.0
- task: DotNetCoreCLI@2
inputs:
versionSpec: 4.7.0
command: custom
custom: tool
arguments: install --tool-path . nbgv
displayName: Install NBGV tool
condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false))

- task: DotNetCoreCLI@2
inputs:
command: build
projects: Rx.NET/Source/build/setversion.csproj
arguments: -c $(BuildConfiguration)
- script: nbgv cloud -a -p Rx.NET\Source
displayName: Set Version
condition: eq(variables['system.pullrequest.isfork'], false)
condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false))

- task: DotNetCoreInstaller@0
inputs:
version: '2.1.400-preview-009171'

- task: VSBuild@1
- task: MSBuild@1
displayName: Build System.Reactive.sln
inputs:
solution: Rx.NET/Source/System.Reactive.sln
vsVersion: 15.0
msbuildArgs: /restore /t:build /p:CreatePackage=true /p:NoPackageAnalysis=true /p:PackageOutputPath=$(Build.ArtifactStagingDirectory)\artifacts
solution: Rx.NET/Source/System.Reactive.sln
msbuildArguments: /restore /t:build /p:CreatePackage=true /p:NoPackageAnalysis=true /p:PackageOutputPath=$(Build.ArtifactStagingDirectory)\artifacts
platform: $(BuildPlatform)
configuration: $(BuildConfiguration)
maximumCpuCount: true
Expand All @@ -36,12 +34,11 @@ steps:
arguments: pack Rx.NET/Source/facades/System.Reactive.Compatibility.nuspec -Version $(NBGV_NuGetPackageVersion) -MinClientVersion 2.12 -NoPackageAnalysis -outputdirectory $(Build.ArtifactStagingDirectory)\artifacts
condition: eq(variables['system.pullrequest.isfork'], false)

- task: VSBuild@1
- task: MSBuild@1
displayName: Build for Test (ppdb) workaround
inputs:
solution: Rx.NET/Source/System.Reactive.sln
vsVersion: 15.0
msbuildArgs: /t:build /p:DebugType=portable
solution: Rx.NET/Source/System.Reactive.sln
msbuildArguments: /t:build /p:DebugType=portable
platform: $(BuildPlatform)
configuration: $(BuildConfiguration)
maximumCpuCount: true
Expand Down
7 changes: 0 additions & 7 deletions Ix.NET/Source/build/setversion.csproj

This file was deleted.

8 changes: 0 additions & 8 deletions Ix.NET/Source/build/version.json

This file was deleted.

7 changes: 0 additions & 7 deletions Rx.NET/Source/build/setversion.csproj

This file was deleted.

10 changes: 0 additions & 10 deletions Rx.NET/Source/build/version.json

This file was deleted.

2 changes: 1 addition & 1 deletion Rx.NET/Source/global.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"msbuild-sdks": {
"MSBuild.Sdk.Extras": "1.5.4"
"MSBuild.Sdk.Extras": "1.6.46"
}
}

0 comments on commit 7e2323f

Please sign in to comment.