Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize package versions for 3.1.0 #1290

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Stabilize package versions for 3.1.0 #1290

merged 1 commit into from
Nov 13, 2019

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 7, 2019

CC @mmitche @dougbu

I'll merge this once we got the all-clear for 3.1-preview3

@wtgodbe wtgodbe requested a review from dougbu as a code owner November 7, 2019 20:41
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 7, 2019

F:\workspace_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X [3.1.0-ci, )" or update the version field in the nuspec. [F:\workspace_work\1\s\src\Razor\src\Microsoft.AspNetCore.Razor.LanguageServer.Common\Microsoft.AspNetCore.Razor.LanguageServer.Common.csproj]

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 7, 2019

@dougbu @aspnet/build any ideas on the above error? The same thing is happening in every build, but is only treated as an error on Windows Debug. Also seeing it in dotnet/efcore#18804

@mmitche
Copy link
Member

mmitche commented Nov 7, 2019

@dougbu @aspnet/build any ideas on the above error? The same thing is happening in every build, but is only treated as an error on Windows Debug. Also seeing it in aspnet/EntityFrameworkCore#18804

Not sure why there are differences in error behavior, but you'll find that you can't stabilize in some cases until all the inputs are stabilized.

@wtgodbe wtgodbe merged commit d29aca1 into release/3.1 Nov 13, 2019
@wtgodbe wtgodbe deleted the Stabilize branch November 13, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants